riscv / configuration-structure

RISC-V Configuration Structure
https://jira.riscv.org/browse/RVG-50
Creative Commons Attribution 4.0 International
36 stars 16 forks source link

Address some of Greg's feedback. #72

Closed timsifive closed 2 years ago

timsifive commented 2 years ago

Also slight reorganisation to (hopefully) make more sense.

allenjbaum commented 2 years ago

Sorry to have to pile on here. I think you're too close to this, so you're not explaining things that are obvious to you. This doc says: Part of the socket standard is the fact that the root CS exists at 0x3000. Which socket standard is this? IS this a proposed platform spec standard? This doc doesn't actually say that mconfigptr is a CSR - that should be clear.

From this example I think that there is

Alternately, there could be a ROM on the motherboard that contains all of the CSes, and it ignores all irrelevant address bits to keep it small.

But, in the former case: what happens when someone tries to follow the breadcrumbs to some socket, and that socket isn't even plugged in? (a bus error?). In the latter case: the ROM is accessible - but the socket isn't populated. How is that discovered?

timsifive commented 2 years ago

I'll address Allen's comments, which don't really pertain to this PR, later somewhere else.