search

riscv / docs-resources

https://lists.riscv.org/g/sig-documentation
Creative Commons Attribution 4.0 International
23 stars 14 forks source link

Latest PDF theme fails #13

Closed sameo closed 5 months ago

sameo commented 5 months ago

When using the latest docs-resources code (005cb0db1c46c31fff163914f3e480dbda0306be), I get the following error:

❯ make build-no-container
Starting build...
make SKIP_DOCKER=true build-docs
make[1]: Entering directory '/home/samuel/devlp/specs/riscv/riscv-ap-tee-io'
asciidoctor-pdf --trace -a compress -a mathematical-format=svg -a revnumber=v0.0.0 -a revremark=Draft -a revdate=2024-04-30 -a pdf-fontsdir=docs-resources/fonts -a pdf-theme=docs-resources/themes/riscv-pdf.yml  -D build --failure-level=ERROR --require=asciidoctor-bibtex --require=asciidoctor-diagram --require=asciidoctor-mathematical src/riscv-cove-io.adoc
asciidoctor: ERROR: could not locate or load the built-in pdf theme `docs-resources/themes/riscv-pdf.yml' because of NoMethodError undefined method `each' for "646b74":String; reverting to default theme
make[1]: *** [Makefile:61: riscv-cove-io.pdf] Error 1
make[1]: Leaving directory '/home/samuel/devlp/specs/riscv/riscv-ap-tee-io'
make: *** [Makefile:83: build-no-container] Error 2
sameo commented 5 months ago

When using commit 37ec11de071c846b687386b4315000c7fd8e3195 I do not see this error.

wmat commented 5 months ago

Did you populate the submodule?

git submodule update --init

sameo commented 5 months ago

Did you populate the submodule?

git submodule update --init

Yes, I did. But when using the latest HEAD for that submodule, build fails.

The current ricv-ap-tee-io repo is at https://github.com/riscv/docs-resources/commit/37ec11de071c846b687386b4315000c7fd8e3195 and build succeeds.

When trying to update it to https://github.com/riscv/docs-resources/commit/005cb0db1c46c31fff163914f3e480dbda0306be, it fails. See https://github.com/riscv-non-isa/riscv-ap-tee-io/pull/117

wmat commented 5 months ago

Got it. There's a bug in the riscv-pdf.yml file. Working on it now.

sameo commented 5 months ago

I think this is fixed with #14 ?

wmat commented 5 months ago

I still can't build the PDF locally. And oddly, if I add a new theme file into docs-resources/themes it builds. However, it creates a PDF with root permissions, so make clean breaks.

wmat commented 5 months ago

@sameo closing this one as the riscv-ap-tee-io repo is building with the latest version of docs-resources. Also, make build-no-container works locally.