search

riscv / docs-spec-template

https://lists.riscv.org/g/sig-documentation
Creative Commons Attribution 4.0 International
18 stars 19 forks source link

refactor makefile: var to inject adoc options; change to build dir instead of outfiles #30

Closed kbroch-rivosinc closed 5 months ago

rpsene commented 5 months ago

@wmat we will need to revert it. This broke the PDF generation process.

wmat commented 5 months ago

Ok go ahead. I can look at it tomorrow.

Bill Traynor Documentation Build and Release Engineer RISC-V International

On Fri, Jan 26, 2024 at 8:36 PM Rafael Sene @.***> wrote:

@wmat https://github.com/wmat we will need to revert it. This broke the PDF generation process.

— Reply to this email directly, view it on GitHub https://github.com/riscv/docs-spec-template/pull/30#issuecomment-1912902993, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAN6ZCOVNJCSMMZB2QW3FLYQRK2VAVCNFSM6AAAAABCIDSHF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSHEYDEOJZGM . You are receiving this because you were mentioned.Message ID: @.***>

rpsene commented 5 months ago

@wmat in fact, we need to review all the commits from the last week. There was a lot of changes and I'm not sure which broke the process.

kbroch-rivosinc commented 5 months ago

@wmat we will need to revert it. This broke the PDF generation process.

I think the only problem might be that I didn't tell the action the new location of the pdf. (Although it would probably be good for the action to fail if it doesn't find a pdf)

I corrected this with PR #31

I didn't change the action to fail if it doesn't find a pdf.

rpsene commented 5 months ago

@kbroch-rivosinc I had to force and push the fix given the necessity to use the template for a new spec. Thanks for the PR :)