riscv / riscv-fast-interrupt

Proposal for a RISC-V Core-Local Interrupt Controller (CLIC)
https://jira.riscv.org/browse/RVG-63
Creative Commons Attribution 4.0 International
245 stars 49 forks source link

Clean up section 9.1.1. (xcliccfg registers) #322

Closed JamesKenneyImperas closed 1 year ago

JamesKenneyImperas commented 1 year ago

I think this section needs cleaning up a bit:

  1. The registers are now 32-bit, not 8-bit as stated (alternatively, there are several 8-bit mode-specific sub-registers in each xcliccfg register).
  2. I can't see anything that says that the distinct snlbits and unlbits fields in different xcliccfg registers are aliases of each other, which I think they are. It would help to say this I think.
  3. Presumably the snlbits field in mcliccfg is only present if ssclic is present, and unlbits fields in mcliccfg and scliccfg are only present if suclic is present, with these fields being WPRI-0 otherwise; is this right?

Thanks.

dansmathers commented 1 year ago

closed by #330