search

riscv / riscv-fast-interrupt

Proposal for a RISC-V Core-Local Interrupt Controller (CLIC)
https://jira.riscv.org/browse/RVG-63
Creative Commons Attribution 4.0 International
245 stars 49 forks source link

issue #401 - First round of changes to improve clarity of document. Removed mention of U-mode interrupts. #403

Closed james-ball-qualcomm closed 2 months ago

james-ball-qualcomm commented 2 months ago

This PR contains my many updates to the CLIC spec to improve clarity. Based on discussions in the Fast Interrupt TG, I removed references to user-mode interrupts to simplify the specification. If the N extension someday moves forward towards ratification, we can add in support to the CLIC specification at that time.

christian-herber-nxp commented 2 months ago

i went roughly half through this PR for now. I gave some comments, but I don't think I can review this as a whole. In general, it is good to limit the scope of a PR to one issue to enable a good review. E.g. a single PR to fix the notion of mode/level would be easy to review.

james-ball-qualcomm commented 2 months ago

I’ll look at the table build error. Works fine in my VSCode preview but I should be building this first before doing a PR. Sorry, I’m still ramping up on these sorts of tasks.

From: Christian Herber @.> Sent: Wednesday, September 4, 2024 1:01 AM To: riscv/riscv-fast-interrupt @.> Cc: James Ball @.>; Author @.> Subject: Re: [riscv/riscv-fast-interrupt] issue #401 - First round of changes to improve clarity of document. Removed mention of U-mode interrupts. (PR #403)

WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.

@christian-herber-nxp commented on this pull request.

In src/clic.adochttps://github.com/riscv/riscv-fast-interrupt/pull/403#discussion_r1743257742:

+interrupt input. The mideleg CSR (if present) no longer controls interrupt delegation.

+

+=== CLIC Extensions Summary

+

+This table provides a summary of the extensions supported by the CLIC.

+

+[%autowidth]

+|===

+| Extension Name | Description

+

+| smclic | CLIC support for M-mode

+| ssclic | CLIC support for S-mode

+| smclicshv | Selective Hardware Vectoring for M-mode

+| smclicconfig | Allows implementations to support different parameterizations of CLIC extensions

+|

+|===

this table is giving an error in the build process

— Reply to this email directly, view it on GitHubhttps://github.com/riscv/riscv-fast-interrupt/pull/403#pullrequestreview-2279292573, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BBRBTGA3S423JRCDLEXE4QDZU242TAVCNFSM6AAAAABNTCHJRGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZZGI4TENJXGM. You are receiving this because you authored the thread.Message ID: @.**@.>>

james-ball-qualcomm commented 2 months ago

I did the merge since it was approved (hope I'm supposed to do this, I'm still learning GitHub)

christian-herber-nxp commented 2 months ago

I did the merge since it was approved (hope I'm supposed to do this, I'm still learning GitHub)

looks good. I would recommend to do a squash merge in future, to make to have one commit on the main branch per PR.