Open ThinkOpenly opened 2 months ago
I support the proposed changes.
I haven't checked how broadly various tools have deprecated the old assembly syntax. I generally use LLVM's (integrated) assembler, modern versions of which error on the old syntax. So I'm OK with deleting the note.
Over time, I'm hoping that such details of assembly language syntax will be migrated to https://github.com/riscv-non-isa/riscv-asm-manual/blob/main/riscv-asm.md . But that is a broader issue.
I support the proposed changes.
Thanks, @nick-knight!
Over time, I'm hoping that such details of assembly language syntax will be migrated to https://github.com/riscv-non-isa/riscv-asm-manual/blob/main/riscv-asm.md . But that is a broader issue.
In the quest for "one source of truth", I certainly hope the RISC-V Sail specification informs the content of the RISC-V Assembly Programmer's Manual, if it is not generated (or partly generated) from it. The Sail specification needs to retain its role as the canonical reference.
Looking at the lastest GitHub released spec, under "Vector Tail Agnostic and Vector Mask Agnostic
vta
andvma
" there is this text:...followed by a table of the valid
vta
andvtm
flags.A first suggestion is to change "adds ... to" in the text above to "has ... in", as it's not apparent what is being added to.
A second suggestion is to add
vsetivli
to the sentence, presuming these flags are also mandatory for it.Accompanying the above table is a note:
Are references to pre-ratified specifications of value in the ratified spec? Presuming not, a third suggestion is to remove this note.
Regardless, this note further confirms that the
vta
andvtm
flags are required.Unfortunately, some later examples of the use of
vsetvli
/vsetivli
do not obviously include the mandatory flags. In (33.6):Thus, a final suggestion is to add some indication or immediate explanation that
vtypei
is a series of flags (not one operand as shown), including some mandatory flags. This explanation comes in a subsection about a page later after content about encodings and thevtype
register layout.