Open Timmmm opened 2 months ago
@neelgala is the author of the bulk of the Python code, so I'll defer to him. But at first blush this seems reasonable.
Commenting here to have just a glimpse of the improvements in software engineering qualities such as Refactorization, Modularization and using as much Optimization techniques as we can for better maintainability and enhancing the readability as well. Tagging a PR also with reference to above.
Refactor and Optimization:: constants.py
/CC @aswaterman and @rpsene
Hi, I was wondering if you would be open to PRs to improve the general software engineering quality of this repo. This is the sort of thing I'm thinking of in increasing order of invasiveness:
pre-commit
, tell it to format all the Python code using Black or Ruff and enforce in CI.pre-commit
. #311pyproject.toml
etc. Publish it on Pypi. #294pre-commit
to enforce them.There's also some low hanging fruit in the actual code:
I can do all that fairly easily but I thought I'd check if you would actually accept those improvements first. Seems like you might a bit review bottlenecked based on the open PRs (who isn't?).