riscv / riscv-profiles

RISC-V Architecture Profiles
Creative Commons Attribution 4.0 International
119 stars 33 forks source link

Clarify that Sstvala applies to virtual-instruction exceptions, too #174

Closed aswaterman closed 4 months ago

aswaterman commented 4 months ago

Both illegal-instruction and virtual-instruction exceptions must populate stval with the faulting instruction.

This is not a change; the behavior was already mandated by the following clause in the hypervisor spec: https://github.com/riscv/riscv-isa-manual/blob/65c6b5d3e69cdc2bd2658f9639fd10553c4b34e0/src/hypervisor.adoc#L2040-L2041

We are replicating that information here for added clarity.

kasanovic commented 4 months ago

should also be added to RVA/B23 profiles.

aswaterman commented 4 months ago

I had already done so as part of the original PR. Or did you spot another place I missed?

kasanovic commented 4 months ago

OK - mistake on my end. Will merge now.