riscv / sail-riscv

Sail RISC-V model
https://lists.riscv.org/g/tech-golden-model
Other
433 stars 159 forks source link

Fix consecutive builds of the OCaml emulator #499

Closed Timmmm closed 3 months ago

Timmmm commented 3 months ago

These OCaml files can be read only, in which case copying them for a second build fails. To work around this use the -f flag which ignores the read-only-ness.

Fixes #407

github-actions[bot] commented 3 months ago

Test Results

712 tests  ±0   712 :white_check_mark: ±0   0s :stopwatch: ±0s   6 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 634d2c53. ± Comparison against base commit 0e9850fe.

Alasdair commented 3 months ago

Looks fine to me.

Currently we generate an ocamlbuild setup but we should probably switch to dune. ocamlbuild is a bit legacy at this point.