search

riscv / sail-riscv

Sail RISC-V model
https://lists.riscv.org/g/tech-golden-model
Other
464 stars 168 forks source link

The sideleg CSR might be deleted #529

Closed KotorinMinami closed 1 month ago

KotorinMinami commented 3 months ago

Recently, I reviewed the latest specification and found that the "sideleg" register no longer exists in the CSR table. Upon further investigation, it appears to have been removed. However, in the sail model, this register and its encoding still exist. Should this be removed to avoid potential issues with illegal encodings in the sail?

jrtc27 commented 3 months ago

It's gated on Ext_N, which there isn't a way to enable unless you patch the source. The only issue that would arise is if the encoding is reused for another CSR. Though it would probably be wise to remove the implementation given the obsolete draft was removed outright from the riscv-isa-manual repo.

jordancarlin commented 1 month ago

Closed by #584