search

riscv / sail-riscv

Sail RISC-V model
https://lists.riscv.org/g/tech-golden-model
Other
461 stars 167 forks source link

Duplicate vector CSR code #548

Closed Timmmm closed 1 month ago

Timmmm commented 2 months ago

The code for reading/writing vector CSRs is duplicated here and here. The latter is not used because the former takes priority.

The code is not actually the same, so something is definitely not right.

trdthg commented 2 months ago

(One more point, The ext_read_CSR functions are also duplicated in the latter file https://github.com/riscv/sail-riscv/blob/31f809346e1020d191b46d519ad6435e2428be39/model/riscv_vext_control.sail#L18-L24