Alasdair
commented
1 month ago Yes, this is an issue I've also been dealing with. I think the solution is to make init_sys a scattered definition so each extension has a function clause init_sys(Ext_Name) that deals with its own state.
If you see my PR here: https://github.com/riscv/sail-riscv/pull/572 the dependency that the riscv core module on the vector extension has to be spelled out - that's one of the big motivators for introducing a simple module system, as it will ensure that these kinds of circular dependencies don't exist and extensions are easily separable from the base ISA.
JosephMoore25
Timmmm
jrtc27
When compiling a minimal RISC-V Sail source into Jib (though I expect this is the same when compiling the emulators) I'm finding that
riscv_sys_control.sailis dependent on the following files:riscv_flen_{F/D}.sailriscv_vlen.sailriscv_vreg_type.sailriscv_vext_regs.sailIn the provided sail-riscv makefile, these are included in the default sources so are always compiled. As I understand, some discussion of a more configurable model (choosing what extensions to enable) has been underway. Of course, not all extensions are segregated, but this means that a relatively large portion of the vector extension is a dependency for compiling the "base" model.
The offending code is defining vector CSRs in
init_sys()and uses some functions defined in the vector files. This is also the case with the floating point extension (either F or D), though this is less impactful asriscv_flen_D.sailis very small. I was able to compile without the above dependencies after removing this code.Separating these definitions into a new (or other existing) file would help reduce the dependencies and make it a bit easier to only (or at least mostly) include subsets of extensions.