search

riscvarchive / riscv-binutils-gdb

RISC-V backports for binutils-gdb. Development is done upstream at the FSF.
GNU General Public License v2.0
147 stars 233 forks source link

Corrections and additions to the .insn directive #216

Closed fpetrot closed 4 years ago

fpetrot commented 4 years ago

Make documentation in line with code in riscv-opc.c for the i, s and b/sb types of the .insn directive. Note that I have not been able to understand the difference between b and sb.

jim-wilson commented 4 years ago

Patches must be sent upstream. See https://sourceware.org/binutils

The FSF requires copyright assignments before a patch can be accepted. Do you have a copyright assignment? Are you willing and able to get one? If not, then it is better to submit bug reports and let someone else who does have a copyright assignment write the patch.

jim-wilson commented 4 years ago

The v2.1 user spec has S and SB instruction formats. The v2.2 user spec has S and B instruction formats. Similarly, v2.1 has U and UJ and v2.2 has U and J. They are primarily format name changes, however I think that there was an implementation bug in older gas versions that confused the SB and/or UJ format implementations, and I don't remember whether any of that old incorrect functionality was retained. It might have been kept for backward compatibility. Or maybe we removed it, in which case B and SB are identical, and J and UJ are identical.

fpetrot commented 4 years ago

Hi Jim,

Le 26/05/2020 à 23:07, Jim Wilson a écrit :

Patches must be sent upstream. See https://sourceware.org/binutils

The FSF requires copyright assignments before a patch can be accepted. Do you have a copyright assignment? Are you willing and able to get one? If not, then it is better to submit bug reports and let someone else who does have a copyright assignment write the patch.

Thanks for the info. I don't have the stamp, and am hardly a contributor to FSF projects, so I will file a bug report.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/riscv/riscv-binutils-gdb/pull/216#issuecomment-634279753, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6PHKFSDIMFDAY4DCT74MLRTQVSLANCNFSM4NK7TH5Q.

-- +-----------------------------------------------------------------+ | Frédéric Pétrot, Pr. Ensimag-TIMA/SLS TIMA lab deputy director | | Phone : +33 4 76 57 48 70 Fluctuat nec mergitur | | Mobile: +33 6 74 57 99 65 Ad augusta per angusta | | http://tima.imag.fr/sls frederic.petrot@univ-grenoble-alpes.fr | +-----------------------------------------------------------------+