riscvarchive / riscv-binutils-gdb

RISC-V backports for binutils-gdb. Development is done upstream at the FSF.
GNU General Public License v2.0
147 stars 233 forks source link

Revert "Change the return type of `match_func` and `constraints` flag to `bfd_boolean`." #218

Closed Nelson1225 closed 4 years ago

Nelson1225 commented 4 years ago

This reverts commit 9d02802920483d07aee78c375f20ec24c2e1f591.

The original report is as follows, https://sourceware.org/pipermail/binutils/2020-June/111383.html

And I have sent a patch to fix this on upstream, https://sourceware.org/pipermail/binutils/2020-June/111405.html

Inlcude the bfd.h in the include/opcode/riscv.h may cause gdbserver fail to build. I just want to use the bfd_boolean in the opcodes/riscv-opc.c, but I didn't realize this cause the build failed. Revert the commit 9d02802920483d07aee78c375f20ec24c2e1f591 should fix the gdbserver build.

As I know we don't support vector in GDB for now, so this should be fine. But in case we need to merge the rvv implementation into FSF binutils someday and forgot this issue, revert the commit 9d02802920483d07aee78c375f20ec24c2e1f591 now seems more safe.