riscv-binutils-2.35-rvb: wrong match for xperm.h

riscvarchive / riscv-binutils-gdb

RISC-V backports for binutils-gdb. Development is done upstream at the FSF.

GNU General Public License v2.0

149 stars 233 forks source link

riscv-binutils-2.35-rvb: wrong match for xperm.h #251

Closed rdolbeau closed 3 years ago

rdolbeau commented 3 years ago

Hello,

at: https://github.com/riscv/riscv-binutils-gdb/blob/3e5f50f31348d05144966545d862a3172d315230/include/opcode/riscv-opc.h#L378

The match value is wrong and should be: #define MATCH_XPERMH 0x28006033 (6 instead of 3 for bits 15-12).

as according to the current bitmanip draft, funct3 for xperm.h is 110 (and not 011). The other forms (.b, .n and .w) are correct.

rdolbeau commented 3 years ago

Closed by #252

Nelson1225 commented 3 years ago

Thanks for sending the PR. The riscv-binutils-2.35-rvb branch is obsolete for now. I think all the rvb related branches here can only guarantee the implementation of the frozen ZBA, ZBB and ZBC. There are no branches here are working on the draft rvb currently. I'm not sure if we will continue to do the following work in the riscv-binutils-2.35-rvb, or in the other branches, we will figure this out soon. Thanks.