Add p-ext support with spec v0.94

riscvarchive / riscv-binutils-gdb

RISC-V backports for binutils-gdb. Development is done upstream at the FSF.

GNU General Public License v2.0

148 stars 233 forks source link

Add p-ext support with spec v0.94 #257

Open linsinan1995 opened 3 years ago

linsinan1995 commented 3 years ago

Add p-ext support with spec v0.93

Andes-tech and Shao-Chung Wang implemented the RISC-V 'p' extension with the spec version 0.51 with Binutils 2.32
Sinan Lin updated the implementation to the spec version 0.93 with Binutils 2.36

kito-cheng commented 3 years ago

nds means abbreviation of andes, which used in Andestech internal only, P extension will become standard extension rather than Andestech specific extension, so I think nds should gone in this implementation.

linsinan1995 commented 3 years ago

Hi @kito-cheng , I did not find a proper prefix for p ext operands, so keep 'nds' as prefix (since old spec also used it as a prefix for intrinsic functions). Prefixes like 'p', 'P', 'r' (rvp) and 'd' (dsp) are taken. I just filed an issue for this problem. Thanks.

Nelson1225 commented 3 years ago

I shouldn't have time to check the encoding, does the encoding conflicts are resolved in the v0.93 spec? If they are resolved, and the previous comments are also fixed, then the patches looks good to me. The operand naming doesn't really matter, just renamed to rps or others are fine to me, just avoid using the vendor prefixes since p is a standard extension. Thanks.

linsinan1995 commented 3 years ago

I shouldn't have time to check the encoding, does the encoding conflicts are resolved in the v0.93 spec? If they are resolved, and the previous comments are also fixed, then the patches looks good to me. The operand naming doesn't really matter, just renamed to rps or others are fine to me, just avoid using the vendor prefixes since p is a standard extension. Thanks.

I will check those encoding conflicts and then inform you. Thanks.

linsinan1995 commented 3 years ago

Some updates on the PR

squash fixup commits
fix wrong indents in bfd/elfxx-riscv.c
change swap16 and smbb32 to be an alias of pkbt16 and mulsr64

Also, I did not find any conflict with the encoding in B ext. Perhaps it has been resolved?

linsinan1995 commented 2 years ago

the new commit fixes an error that csr* instructions can't access RVP csr, and adds a test case.