Closed JohnAZoidberg closed 3 years ago
There was too much code, which wasn't called but it could have generated those SMBIOS table entries:
Now it only has code for those entries:
I did smbiosview on the UEFI shell and the mentioned SMBIOS entries are indeed present.
smbiosview
Here's what happened to the files:
Expanded:
Platform/RISC-V/PlatformPkg/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.c
Deleted File:
Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Merged with E51 code into single file:
Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Added SMBIOS Type 7 for L1 Cache, removed duplicated SMBIOS (Type 4 and 7 code):
Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Graphical representation of the changes: (Grey things were removed)
There was too much code, which wasn't called but it could have generated those SMBIOS table entries:
Now it only has code for those entries:
I did
smbiosview
on the UEFI shell and the mentioned SMBIOS entries are indeed present.Here's what happened to the files:
Expanded:
Platform/RISC-V/PlatformPkg/Library/FirmwareContextProcessorSpecificLib/FirmwareContextProcessorSpecificLib.c
Deleted File:
Silicon/SiFive/E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Silicon/SiFive/U54MCCoreplex/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Merged with E51 code into single file:
Silicon/SiFive/U54/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Added SMBIOS Type 7 for L1 Cache, removed duplicated SMBIOS (Type 4 and 7 code):
Platform/SiFive/U5SeriesPkg/Library/PeiCoreInfoHobLib/CoreInfoHob.c
Graphical representation of the changes: (Grey things were removed)