riscy / shx-for-emacs

An Emacs shell-mode (and comint-mode) extension that enables displaying small plots and graphics and lets users write shell commands in Emacs Lisp.
GNU General Public License v3.0
218 stars 10 forks source link

shx-mode in eshell #3

Closed nayefc closed 6 years ago

nayefc commented 7 years ago

Is there anyway to use shx-mode with eshell? When I run shx-mode in shell, I get this when I hit return which makes it unusable: shx-point-on-input-p: Wrong type argument: processp, nil

riscy commented 7 years ago

Unfortunately there isn't -- shx hooks comint-mode's input/output handling. Many REPLs and regular old shell use comint-mode, but eshell doesn't.

You can check if a buffer's major mode derives from comint-mode by running

M-: (derived-mode-p 'comint-mode)

But I should probably add a descriptive warning when you try to enable shx in a non-comint-mode buffer. Thanks for bringing this to my attention!

riscy commented 6 years ago

Thanks for this. Sorry shx doesn't work in eshell -- looks like that would be a big project.