search

risechain / pevm

Blazingly fast Parallel EVM
MIT License
217 stars 41 forks source link

chore: remove useless `min()` #280

Closed jackwener closed 1 month ago

jackwener commented 1 month ago
jackwener commented 1 month ago

it's easier to review by seeing https://github.com/risechain/pevm/pull/280/files?diff=split&w=1

hai-rise commented 1 month ago

The min is actually needed as fetch_min only returns the previous value. If it is larger than next_validation_idx then we want the local min_validation_idx to be next_validation_idx immediately. Removing it apparently caused a deadlock in CI :pray:.

jackwener commented 1 month ago

The min is actually needed as fetch_min only returns the previous value. If it is larger than next_validation_idx then we want the local min_validation_idx to be next_validation_idx immediately. Removing it apparently caused a deadlock in CI 🙏.

Sorry, it was my oversight....