risechain / pevm

Blazingly fast Parallel EVM
MIT License
217 stars 41 forks source link

Report test name that fails to parse sender address #326

Closed hai-rise closed 2 weeks ago

hai-rise commented 1 month ago

https://github.com/risechain/pevm/blob/24266be8d317bdcbe8f8ac10c6ce34ae7298802d/tests/ethereum/main.rs#L71

varun-doshi commented 2 weeks ago

Is it an acceptable solution if the function signature is changed from:

fn run_test_unit(path: &Path, unit: TestUnit) {

To

fn run_test_unit(path: &Path, unit: TestUnit, test_name:String) {
hai-rise commented 2 weeks ago

@varun-doshi I think we can just report the path, which is more searchable too :pray:.

varun-doshi commented 2 weeks ago

Understood So then passing the path variable to build_tx_env should work(?)

I'd like to take this up

hai-rise commented 2 weeks ago

@varun-doshi That should work, thank you!