search

riseuplabs / crabgrass-core

This repository has moved to https://0xacab.org/riseuplabs/crabgrass
Other
70 stars 30 forks source link

Updating profile image does not change profile image at older files #317

Open jnachtigall opened 9 years ago

jnachtigall commented 9 years ago

I've changed my image under Settings > Icon to another image (anyway, why is the profile image called "Icon"? (german)).

Afterwards all new pages and files I upload have the new image attached to them (good!). However, at the old files (that I upload before changing the image) there is still my old profile image (bad!)

This causes confusion as one might think that these are two different persons. (Actually, I just changed my profile image to a photo of mine because someone with the same first name joined our group... Now it's really a bit confusing, 2 people with similar name and 3 photos/icons ;-)

Maybe an reindexing of the user's files or similar should be done when changing the image.

azul commented 9 years ago

thanks for the report. I changed my profile image recently too, so i will use that to quickly take a look at files i uploaded before. I'm not quite sure which part of the ui you mean. I hope to find it but a screenshot might proof useful eventually.

jnachtigall commented 9 years ago

Now, it's been updated (one or two days later). Don't know why there's been a time lag in the photo update...

It was in the pages listing ("Aktuelle Seiten", i.e. <h2 class="pages">) of a group. There it was in the "Aktualisiert" (Updated) row, i.e. <th class="updated" colspan="2">. Hope this description is sufficient, otherwise I can also sent a screenshot, but would need to edit the image as the group is private (let me know if you still need it, and maybe your email address for a PM) - but as said, now it is all fine.

I am still not closing the bug as you might want to investigate why there's a time lag of about 2 days for updating the profile image for older pages/files. Go ahead and close if you feel it is ok.

azul commented 9 years ago

this sure is an issue. We are caching the page rows and the cache key should change when the avatar of a user changes. Now it may have changed for a different reason. For example the timestamp may have changed from "yesterday" to "wednesday" or so. We need to make sure the updated_at timestamp of the page changes.

elijh commented 8 years ago

this is also true for groups, the avatar is too aggressively cached.