search

rishabh3112 / gridsome-plugin-pwa

PWA plugin for gridsome
MIT License
30 stars 18 forks source link

refactor: rename outDir to outputDir #15

Closed foxted closed 5 years ago

foxted commented 5 years ago

Proposing to change the outDir config setting to be outputDir.

To be in line with vue-cli convention: https://cli.vuejs.org/config/#outputdir and this PR on gridsome: https://github.com/gridsome/gridsome/pull/754

This will remove the following warnings as well: 

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/manifest.js:17:50

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/manifest.js:19:46

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/manifest.js:26:53

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/manifest.js:28:73

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/service-worker.js:29:55

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/service-worker.js:33:27

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/service-worker.js:39:50

The outDir config is renamed to outputDir.
./node_modules/gridsome-plugin-pwa/files/service-worker.js:21:45
rishabh3112 commented 5 years ago

Thanks @foxted for sending PR ❤ Looks good to me!