search

rishabh3112 / gridsome-plugin-pwa

PWA plugin for gridsome
MIT License
30 stars 18 forks source link

Add sizes=any to .ico icon #81

Closed RehanSaeed closed 3 years ago

RehanSaeed commented 3 years ago

Stops Chrome downloading and using the .ico and uses the .svg instead.

https://css-tricks.com/favicons-how-to-make-sure-browsers-only-download-the-svg-version/

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a2f3c861b44f89dfe86ccbf9d596a83c1820c83:

Sandbox Source
basic Configuration
rishabh3112 commented 3 years ago

Hi @RehanSaeed, Sorry for being super inactive here 😅 Thanks for the pull request! I myself is not able to give time to the plugin it needs. Will you be willing to be a co maintainer for this plugin?

RehanSaeed commented 3 years ago

Sure!

rishabh3112 commented 3 years ago

@RehanSaeed I have sent you the request. Also, lets connect on twitter so that we can directly communicate with ease in future regarding this. (Update: Followed you for this, but DMs not open. If not possible, you suggest any other means by which you are comfortable to communicate directly) Thank you very much for this!