search

rishabhbhatia / react-native-awesome-alerts

Awesome alerts for React Native, works with iOS and Android.
MIT License
525 stars 71 forks source link

No testID to use for Automated tests #95

Closed fredlemieux closed 3 years ago

fredlemieux commented 3 years ago

Firstly, nice library, thanks for the effort.

The issue that I'm having is when writing E2E tests using cypress, I'm not able to click() the confirm/cancel buttons. Setting a testID for both would allow people to access them in automated tests.

I'm happy to create a PR for this.

fredlemieux commented 3 years ago

https://github.com/rishabhbhatia/react-native-awesome-alerts/pull/96

rishabhbhatia commented 3 years ago

Hey @fredlemieux appreciate the PR. Added a small suggestion for it, please have a look.

fredlemieux commented 3 years ago

Thanks, I'll have a look now.

rishabhbhatia commented 3 years ago

This change is released with v1.5.2.