Behaviour of tiles rpositories

[GoogleCodeExporter]

Hi Helder.

I would like to discuss behaviour of tile repositories.

If some method is useful it has to be in class tileRepo. If it is not used it 
should not be listed in tileRepo.

Can you confirm following methods should be removed? 
def do_export()
def remove_old_tile()

If you removed them from tileRepoFS and tileRepoMGMaps, why not from 
tileRepoSQLite3?

While ago remove_old_tile() was used for removing tiles older than 'sometime'. 
There is no such functionality now? If forceupdate is set, tiles are repeatedly 
downloaded on each move of the map. Is it OK?

Original issue reported on code.google.com by standa31...@gmail.com on 29 Jan 2011 at 4:35

[GoogleCodeExporter]

I will look into this, maybe it was a mistake on my part to remove those 
methods...

Original comment by heldersepu on 30 Jan 2011 at 5:47

[GoogleCodeExporter]

I'm checking on tilesRepoFS.py and the deletion of the old tile when 
forceupdate is done in:
def get_png_file
it calls fileUtils.delete_old and that is not working properly... 

Original comment by heldersepu on 30 Jan 2011 at 11:36

[GoogleCodeExporter]

I'm doing more research and I guess the logic in def get_png_file is not right, 
the file gets overwritten even if the tile is not deleted.

Original comment by heldersepu on 30 Jan 2011 at 11:44

[GoogleCodeExporter]

I fixed the issue with forceupdate that tiles are repeatedly downloaded, see 
r1124

Original comment by heldersepu on 6 Feb 2011 at 6:00

[GoogleCodeExporter]

Now I'm looking to the tileRepoSQLite3:
- I do not see any def do_export() in that module, all the map export is done 
in mapServices.py

- def remove_old_tile can be removed if you want that is not a problem, but  I 
see that in def get_png_file there is no time check to delete the tiles, that 
should be changed

Can we close this issue?

Original comment by heldersepu on 6 Feb 2011 at 6:15

[GoogleCodeExporter]

Original comment by heldersepu on 28 Apr 2012 at 12:57

• Changed state: Done