rishadhabib / STAT545-547-hw-habib-rishad

GitHub repository for remainder of STAT 545A homework submissions
0 stars 0 forks source link

hw05 ready for grading #4

Open rishadhabib opened 6 years ago

rishadhabib commented 6 years ago

I learnt a lot from this course, looking forward to the 2nd part. My last homework is here

As always, thanks for your feedback and comments =)

swynes commented 6 years ago

Hi Rishad,

Good work on the fifth homework. I appreciate you organized your repo is and how organized your md files are.

Successes

One quick thought:

I found the arrange function did not rearrange data in ggplot. When you used the arrange function you were applying it to an object where you had already reordered the data, and that reordering was preserved. Then you arranged the data to give you the same result and nothing had changed. But I believe that if you had used the arrange function by another variable (GDP per capita etc.) it still would not have altered the plot.

Hope you enjoyed the course!

margotgunning commented 6 years ago

Hi @rishadhabib ,

I really liked your main README. Your files were very well organized, and I liked how you provided links to all of the files found in each of the homework folders. Well done. The HW05 README was short, and concise, as was your progress report. I also had difficulties saving/embedding the plots into my final report!

I liked how your provided links to different sections of your report right at the very top underneath your main header; it made it very easy to navigate. I agree with the comment from swaynes about your arrangement of a reordered object; nevertheless, you did show how fct_reorder worked, and produced a nice plot. I would have liked to see some form of interpretation added to the plot in your commentary. Similarly, I would have liked to see some commentary about how write/read_csv changed or did not change the structure of the dataset; but I did like your use of the ~ for the path names.

You used a good colour palette that made the different continents easy to see, and you demonstrated an understanding of many of the different flags for ggplot that we learned about throughout our classes. I liked your use of a minimal theme for the background to make the data points easier to see. Again, I would have liked to see a bit of commentary for graph interpretation here.

Good job also figuring out how to save the plot, and link it into your github page.

Overall, well done!

Cheers,

Margot