search

rishadhabib / STAT545-547-hw-habib-rishad

GitHub repository for remainder of STAT 545A homework submissions
0 stars 0 forks source link

hw09 is ready for grading #8

Open rishadhabib opened 6 years ago

rishadhabib commented 6 years ago

Hi! You can file my R package here .

Thanks

AnhKhoaVo commented 6 years ago

Hi @rishadhabib,

Overall, you satisfied the homework assignment. Good job.

However, I think that it would make it much easier to navigate through your homework if you can put the code stand out from the instructor's examples. Moreover, If you can add some rmd explaining what your package could do, that would save me time digging through it.

Your box-cox transformation looks correct and decent. I like that you add check test to see if values are negative first (something I forgot to do). I feel like you can also add inverse cox-box and some special features in your package too. However, overall, what you did meets the standard. Good job.

margotgunning commented 6 years ago

Hi @rishadhabib,

Overall, I agree with the above comments re: fulfilling all the needs for the assignment ie) vignette, RMD, DESCRIPTION, LICENSE ect, and perhaps making it more your own ( I think you forgot to change the name from Vincenzo Coia to your own in a few files).

I was able to download your powers package from your Powers repo; however, in your README.md, you have vincenzocoia powers powers package in your installation instructions, so I had to change the name. I was able to use the square/cube/reciprocal /box-cox functions, and I believe they were all working properly. Your Documentation for the functions was good, but I would suggest perhaps adding a bit more about the box-cox transformation and what it does. I like how you added the conditional statement about y being less than 0, and the customized error message that you added.

Your testthat R code was sufficient in testing the ability of the cube, reciprocal functions to transform numeric values, but I would have liked to see some testing for the boxcox transformation as well, and perhaps a test that was expected to fail ie) what happens when you put a string in. Overall, your code for testthat, and your functions was simple and concise.

Overall, you did a good job at creating your first R package!

Cheers, Margot