search

rishavjaiss / movie-search

Mini web-app build on React to search and display movies.
https://rishavjaiss.github.io/movie-search/
0 stars 2 forks source link

Add Sort and Filter feature #4

Open rishavjaiss opened 3 years ago

rishavjaiss commented 3 years ago

Hi,

This issue is opened to implement sorting and filter feature to the results obtained on search. Code of Conduct To be followed strictly : You should generate your own API key from here - https://www.themoviedb.org/documentation/api and only use that.

Happy Hacktober!

cjharkins commented 3 years ago

I'll take it!

rishavjaiss commented 3 years ago

Thanks for your interest. Please follow the code of conduct @cjharkins. Assigning this to you.

cjharkins commented 3 years ago

@rishavjaiss you are aware that your API key is exposed?

rishavjaiss commented 3 years ago

Oh no! This project was untouched for long. Thanks for pointing out. I have removed it @cjharkins. Start working on it.

cjharkins commented 3 years ago

@rishavjaiss can you check the permissions on this repository. I'm trying to push up a new branch for PR and I'm getting a 403 (unauthorized). Thanks!

rishavjaiss commented 3 years ago

@cjharkins make the PR to the main branch. This shouldn't give an error :/

cjharkins commented 3 years ago

@rishavjaiss I am trying to push my local branch up to this repo so I can make a PR

rishavjaiss commented 3 years ago

Haven't you forked the repo before making changes? I guess if you fork and make changes and then make the pr that shouldn't give any error. I am new to open source collaboration. Please check.

cjharkins commented 3 years ago

I did not fork, would you like me to fork it or contribute directly to this project?

rishavjaiss commented 3 years ago

Ah yes. I don't know if there's other better way to do so? I have myself been doing like this so i know this one way only.

rishavjaiss commented 3 years ago

Hey @cjharkins , really appreciate your work. I read on the internet that it's better to make a branch and keep your version of code separate. I can see you are using xml. Please give me some time I'll check how to allow contributors to make branches and make pr to that and then I'll notify you. Your involvement helped me learn something new on GitHub! Thanks man.

cjharkins commented 3 years ago

Hey! No worries.

Any XML outside of ReactJSX shouldn't be in there, you may be viewing older commits, ensure you are looking at the most recent commits and updates for that branch. There were some .idea files that made it's way into my commit I have deleted those files as well as added to .gitignore.

rishavjaiss commented 3 years ago

Yes I have now seen the latest code which you made the pr with. I have completely understood the approach and the code. But I was thinking to try the branching way which I believe is most feasible and professional as that will keep my version intact and your features separate. I'll notify you asap then can you make the pr to a separate branch? Thanks for your contribution.