search

rishichawda / react-native-qrcode-generator

A minimal QRcode component for React Native
https://www.npmjs.com/package/react-native-qrcode-generator
MIT License
32 stars 12 forks source link

typescript-types #20

Closed wpdas closed 4 years ago

wpdas commented 4 years ago

Typescript types were included to be used in TS projects.

rishichawda commented 4 years ago

Hi @Wpdas. Thanks for your contribution! Added in the new release v1.2.2 🎉.

PS: On a side note, while contributing to other repositories, please check the allow edits from collaborators/owners of the repository so that it could be easier to make some one-line changes quickly. 😄

wpdas commented 4 years ago

Hi @rishichawda. You're welcome. Sorry man, where is this information (allow edits)?

rishichawda commented 4 years ago

You should be able to see it while creating the pull request - in the section on the right. Here's the wiki.

wpdas commented 4 years ago

Thanks, sorry for that haha.

rishichawda commented 4 years ago

No problem.