search

rishichawda / react-native-qrcode-generator

A minimal QRcode component for React Native
https://www.npmjs.com/package/react-native-qrcode-generator
MIT License
32 stars 12 forks source link

Remove this fork and rewrite a new library for this. #8

Open rishichawda opened 5 years ago

rishichawda commented 5 years ago

This code is shit. Remove everything, rewrite and publish as v1.1 under the react-native-qrcode-generator package name.

gitstud commented 4 years ago

@rishichawda Let me know if you'd like help with that :)

rishichawda commented 4 years ago

@gitstud I would appreciate it very much but I am not getting time myself to work on this. I will notify you as soon as I start! Fingers crossed for this weekend. 🤞

douglasjunior commented 4 years ago

I would recommend the React Native QRCode SVG, as it renders native Views without the need for workarounds with canvas and webview.

rishichawda commented 4 years ago

Thanks for the recommendation. I have used that one before. Part of the reason why I had forked and maintained this was because I needed to use it in one of the projects and needed to generate a plain QRCode, nothing fancy. react-native-qrcode-svg library comes with other functionalities which I didn't need. That means it comes with the additional code that I didn't need. Hence, this.

douglasjunior commented 4 years ago

SVG overhead is much less than the version using webview.

The react-native-qrcode-svg just use the qrcode to generate the paths and then converts the paths to use the react-native-svg, it is a very lean implementation, there is no extra code or workarounds like in webview version that uses canvas and web others web technologies.

Think, with webview you need to load an entire browser just to display a QR code image.

rishichawda commented 4 years ago

As I have said earlier, this was forked for a project where I needed a simple QRCode view. That project already had a WebView. So this was the best option for that project. I'm aware of the internal implementation of the library you have mentioned and would undoubtedly use for other projects where it seems fit. I'm also mindful of how badly this library is doing this. Hence this issue was created.