search

rishipr / teams

Work management platform for teams, inspired by Asana and built using a full JavaScript stack
95 stars 54 forks source link

full-install created the symlink to the original teams folder instead of creating the node_modules folder with client side dependencies #1

Open cloudchallengers opened 5 years ago

cloudchallengers commented 5 years ago

Hi,

When I ran the command "npm run full-install", it worked fine for the outer package.json i.e. created a node_modules folder in root directory with the listed dependencies in package.json file. But, within "client" folder it created a node_modules folder, which contained a symlink to the original "teams" folder. What I expect is, it should have created install the client side dependencies within this node_modules folder. I am doing this on windows machine and following is how it looks there.

image

I understand that it can be resolved by deleting the node_modules folder created within client folder and running the npm install command within the client folder. But not sure why it didn't worked as provided in the repo's description. Is this some OS/Machine specific issue ?

Kindly Guide.

Thanks

ya332 commented 4 years ago

Expected behavior is that npm run full-install will create two node_modules folder: one in client folder and one in the root directory, because it simply runs npm install in those folders consecutively. I am also running windows, and didn't get a symlink. Could you try to reproduce the issue by deleting the node_module folders, deleting the lock files and then running npm run full-install again?