rishuinfinity / WallpaperSwitcher

Gnome Extension to switch wallpaper after a given interval
GNU General Public License v3.0
33 stars 6 forks source link

Broken on Gnome 45 #27

Open Echelon101 opened 1 year ago

Echelon101 commented 1 year ago

Unable to load if metadata.json is modified for gnome 45

khalangy commented 1 year ago

Is it possible to update the extension for gnome 45 https://blogs.gnome.org/shell-dev/2023/09/02/extensions-in-gnome-45/ ?

lukedupin commented 1 year ago

Here are the lines of code that are the problem:

prefs.js

////////////////////////////////////////////////////////////
// Const Imports
const {Gtk,Adw,Gio,GLib,Gdk,GdkPixbuf}  = imports.gi;
const ExtensionUtils = imports.misc.extensionUtils;
const Me             = ExtensionUtils.getCurrentExtension();
const lib            = Me.imports.lib;

lib.js

//Const Variables
const Gio            = imports.gi.Gio;
const GLib           = imports.gi.GLib;
const ExtensionUtils = imports.misc.extensionUtils;
const Me             = ExtensionUtils.getCurrentExtension();
const homeDir       = GLib.get_home_dir();

extension.js

//Const Variables
const Gio = imports.gi.Gio;
const GLib  = imports.gi.GLib;
const Mainloop = imports.mainloop;
const ExtensionUtils = imports.misc.extensionUtils;
const ExtensionManager = imports.ui.main.extensionManager;
const Me             = ExtensionUtils.getCurrentExtension();
const lib            = Me.imports.lib;
bearpawmx commented 1 year ago

I just upgraded to Gnome 45 and found that this extension no longer works. Are there any plans to support Gnome 45 or update this extension?

lukedupin commented 12 months ago

Not that I've heard. I've spent around 15 minutes trying to figure out how to get a dev environment setup that will produce stack traces and haven't figured it out. I had a stack trace setup years ago that as used to fix the dark mode update but I can't find those notes. If I ever get some time and enthusiasm or the main dev does, I'm sure the problem can fixed relatively quickly.

Chantology commented 11 months ago

I want for my Fedora upgrade until this is fixed (hopefully). I really like this extension but I am not able to code..

Maybe reaching out in the Gnome Matrix chat helps? https://matrix.to/#/#community:gnome.org

Or maybe in the official Gnome Forum? https://discourse.gnome.org/

I read there were some big changes for extension in the last version and many developers needed more time to upgrade to the latest version. There might be many developers who now might be able to help.

fdmarcin commented 11 months ago

@Chantology I moved to this extension and it works with the new Gnome: https://extensions.gnome.org/extension/6281/wallpaper-slideshow/

Chantology commented 11 months ago

@fdmarcin thanks a lot for this tip! I will then switch to Wallpaper Slideshow until this issue is fixed.