search

risingisland / GetSimpleCMS-CE-3.3.20

GNU General Public License v3.0
2 stars 1 forks source link

Page level 2 is not visible in the page management #4

Closed VeNick-GS closed 1 year ago

VeNick-GS commented 1 year ago

Hi @risingisland

New bag was found with page management. When I create 2 level page like: Nav_structure

then DropDown1 page is not visible on the Page management: Page_management

Button "Show all pages" open it but shows not correctly: Page_management_2

After changing an order of parent pages:

Page_management_3

page DropDown1 is visible: Page_management_4

I have tested the same example with GS CE 3.3.18.1 - there is no such bug.

risingisland commented 1 year ago

OK, I will take a look at this soon. As a favor, to make this easier, please let me know what plugins you are using. I didnt realize you were using i18n menu and couldnt figure out why everything was different. Try this first to see if this fixes it: In gsconfig.php, in front of line 46 add a "#" in front of "define('GSSORTPAGELISTBY','menu'); " and tell me if this fixes problem.

VeNick-GS commented 1 year ago

Line 46 doesn't help. I use 2 langs. Plugins used: plugins

The bug is only when I add Page 3: plugins_2 plugins_3

The same problem with versions 3.3.19 and 3.3.18.1 on PHP 7.4.8. With PHP 8.1 there are no problems.

Version 3.3.16 on PHP 7.4.8 is OK.

risingisland commented 1 year ago

So, just to understand, this problem is only x.18-.19 on php7.4. Both work fine on 8.1. Is that correct?

I actually didnt know 3.3.16 worked on PHP 7.4. I dont think I tried it :)

I thought it might have been because of recent update I did, but it sounds like is an existing bug in the plugin if it was also a problem in the x.18 version. I will pass this over to @multicolor-rgb to see if he has any ideas.

VeNick-GS commented 1 year ago

Correct.

Core 3.3.16 with latest i18n plugins is working on PHP 7.4

risingisland commented 1 year ago

OK, so, I have been trying to re-create this issue, but can not. I have created this structure, at it works for me on both 7.4 and 8.1 image So, I am not sure what is going on. I will have Multi take a look and see if he can reproduce this error.

risingisland commented 1 year ago

The version of i18n you are using is from the CE repo or GS website? I think they are the same, but just checking.

VeNick-GS commented 1 year ago

I use i18n installed with CE downloader plugin and I tested with three different installations with the same bug. Please try to test with two language pages - I think the problem is there.

risingisland commented 1 year ago

OK, will give that a try and see if that is the problem. Will let you know as soon as I find something.

multicolor-rgb commented 1 year ago

proof Hi! Problem is not our CE version but style on i18n base. I fixed this, soon on repo. Now on download here: https://github.com/multicolor-rgb/i18n-navigation---i18n-base-CE-edit

VeNick-GS commented 1 year ago

Hi @multicolor-rgb Reinstallation of plugins did not fix the problem. Only after full reinstallation of GS and new installation of the plugins this problem was solved! Thank you for great job!

risingisland commented 1 year ago

Probably a cache problem would be my guess. ctrl+F5 to force refresh, or try opening in private/incognito mode to check. Glad this fix did the job!

VeNick-GS commented 1 year ago

Cleaning the cache and ctrl+F5 did not help. But any way bug is fixed! Thank you!