fix: select * panic in subquery

risinglightdb / risinglight

An educational OLAP database system.

Apache License 2.0

1.59k stars 211 forks source link

fix: select * panic in subquery #821

Closed caicancai closed 9 months ago

caicancai commented 9 months ago

close: #820

caicancai commented 9 months ago

I'm not sure if this is a good idea cc @skyzh

wangrunji0408 commented 9 months ago

As explained in https://github.com/risinglightdb/risinglight/issues/820#issuecomment-1845293586, the right way to fix this bug is not as easy as simply ignoring the unwrap error. (The unwrap is used here because I assume the lookup should always return something. But actually it doesn't, which means that something is wrong in column analysis.)

I'm sorry for not clarifying in time. 🥵