search

risinglightdb / sqllogictest-rs

Sqllogictest (dialect with extensions) parser and runner in Rust.
Apache License 2.0
172 stars 45 forks source link

Add `update_record_with_output` function and tests #130

Closed alamb closed 1 year ago

alamb commented 1 year ago

~Draft as it builds on https://github.com/risinglightdb/sqllogictest-rs/pull/129~

Rationale

I want to be able to update Records given the output of a particular run (see https://github.com/apache/arrow-datafusion/issues/4570)

Changes

  1. Add update_record_with_output function
  2. Tests

I think this is my last planned PR to sqllogictest for a bit (I want to go try and integrated this into DataFusion upstream first)

alamb commented 1 year ago

@xxchan would you like me to add tests to this PR or do you plan to merge this one and have me add more tests as a follow on PR?

xxchan commented 1 year ago

Let's merge it first and improve it later, since it generally looks good and works well in my manual testing.

alamb commented 1 year ago

Let's merge it first and improve it later, since it generally looks good and works well in my manual testing.

Here is a follow on PR https://github.com/risinglightdb/sqllogictest-rs/pull/131#