Tracking: run SQLite sqllogictest suite

[skyzh]

We can add a SQLite backend to sqllogictest-bin and see how compatible it is with the original SQLite's sqllogictest. Though we didn't consider compatibility when we started this project, it's never too late to see how compatible we are for now. 🤣

[xxchan]

123 #124

[skyzh]

🤣🤣

[tv42]

Another thing that'll break those tests is lack of support for valuesort.

[tv42]

Another is that sqlite tests think CAST ( - 55 AS REAL ) should have query I and output -55, not R and -55.000. That is, sqlite doesn't really keep track of floats vs integers, if a float has no decimals it's stored as an integer (https://www.sqlite.org/sqllogictest/doc/trunk/about.wiki).

This one is more for the runner, not the harness. Or for anyone trying to repurpose SQLite tests for other backends.

[tv42]

And #122 (trailing comments)

[tv42]

SQLite & Postgres allow duplicate column names in results: https://github.com/apache/arrow-datafusion/issues/8379#issuecomment-1847906637

[tv42]

SQLite & Postgres allow AVG(DISTINCT), and this is seen a lot in the tests: https://github.com/apache/arrow-datafusion/issues/2408

[xxchan]

Why does that require sqllogictest’s support? 👀

On Sat, 9 Dec 2023 at 06:15, Tv @.***> wrote:

SQLite & Postgres allow AVG(DISTINCT), and this is seen a lot in the tests: apache/arrow-datafusion#2408 https://github.com/apache/arrow-datafusion/issues/2408

— Reply to this email directly, view it on GitHub https://github.com/risinglightdb/sqllogictest-rs/issues/148#issuecomment-1847909768, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJBQZNIKZ2IJRLYEUKS6R63YIOGQTAVCNFSM6AAAAAAT3NBYQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBXHEYDSNZWHA . You are receiving this because you commented.Message ID: @.***>

[tv42]

Sorry, I just realized I wrote datafusion comments here. Nevermind that, those problems are downstream from this project.

[tv42]

And value-wise query results #108 (column-per-line instead of line-per-row).