search

risinglightdb / sqllogictest-rs

Sqllogictest (dialect with extensions) parser and runner in Rust.
Apache License 2.0
172 stars 45 forks source link

fix: correctly support command complete in postgres-extended #151

Closed skyzh closed 1 year ago

skyzh commented 1 year ago

Signed-off-by: Alex Chi iskyzh@gmail.com

This PR also updates the test case in correspondence with pg15.

close https://github.com/risinglightdb/sqllogictest-rs/issues/142

skyzh commented 1 year ago

We can wait until the upstream PR gets merged before proceeding.

skyzh commented 1 year ago

Shall we fork rust-postgres and release our own fork for now?

skyzh commented 1 year ago

But some crates rely on Postgres-types... I'm not sure if we can override dependency when releasing this crate on crates.io.

xxchan commented 1 year ago

👀 What's wrong? Isn't the PR merged?

skyzh commented 1 year ago

Need wait for upstream to release new version

wangrunji0408 commented 1 year ago

I'm not sure if we can override dependency when releasing this crate on crates.io.

I'm afraid not. Unless we also publish a patched version of the dependency. 🤣

skyzh commented 1 year ago

cc @xxchan @wangrunji0408 ready for review

skyzh commented 1 year ago

ping for @xxchan for a final review if you have time :) Thanks!

xxchan commented 1 year ago

Sorry I'm too lazy. I will take a look tonight.