search

risinglightdb / sqllogictest-rs

Sqllogictest parser and runner in Rust.
Apache License 2.0
168 stars 42 forks source link

CLI: support multiple files as input #157

Closed 2010YOUY01 closed 1 year ago

2010YOUY01 commented 1 year ago

Signed-off-by: Yongting You 2010youy01@gmail.com

Close #117 This PR adds multiple blob files CLI support (as #117 suggested)

The following CLI inputs have been tested locally

  1. One unquoted glob 
    > ./target/debug/sqllogictest ./**/*.slt 
...(tests runned)

  2. No input file

    > ./target/debug/sqllogictest
error: The following required arguments were not provided:
<FILES>...

USAGE:
sqllogictest [OPTIONS] <FILES>...

For more information try --help
  3. Multiple globs 
    > ./target/debug/sqllogictest ./examples/basic/*.slt "./examples/condition/*.slt" ./examples/rowsort/rowsort.slt
...(tests runned)
skyzh commented 1 year ago

Just some clippy warnings and we are ready to merge!

2010YOUY01 commented 1 year ago

Just some clippy warnings and we are ready to merge!

clippy is complaining about one formatting problem in multiple files I didn't change

26 -             write!(f, "\nat {}", upper)?;
26 +             write!(f, "\nat {upper}")?;

cargo clippy --fix seems to work, should I add a commit to fix these warnings?

skyzh commented 1 year ago

Yes, thanks a lot! Looks like due to the recent Rust stable upgrade.