Don't log all records (or at-least provide option to control logging)

[vrongmeal]

The library logs all the records while running. The only logs I personally care about is queries and statements. Else, the logs are too noisy to look at!

Can we downgrade the logging from info to debug? Or provide an option to do so? Also an option to control what records to log. This would really be helpful.

PS: I am open to working on this :)

[xxchan]

Hi, IIRC we don’t have any logging in the lib. Can you share how are you using it and what’s the output?

[vrongmeal]

It's this tiny little line – https://github.com/risinglightdb/sqllogictest-rs/blob/7b1a671a02838fb2fd137346627a6530f5cd683a/sqllogictest/src/runner.rs#L574

[xxchan]

Oops… Yeah downgrading it is ok to me. PR is welcomed.

Btw you can also simply disable the log from sqllogictest, since there are no other useful logs. 🤔

[vrongmeal]

I'll submit a PR to downgrade it.

What do you mean by disabling from sqllogictest?

[skyzh]

You can configure your logger to only log events from your crates and disable sqllogictest's.

One way to do this is to use the tracing-env-logger crate (if this is the correct name), and pass RUST_LOG=your_crate=info, so that all logs from sqllogictest will be disabled.

[xxchan]

Yes, check the doc of the logger you are using. Any logger should have similar filtering mechanism. e.g., env_logger

[vrongmeal]

aah thanks for the tip!

[vrongmeal]

Submitted #159 since the log seems unintentional.