search

risinglightdb / sqllogictest-rs

Sqllogictest (dialect with extensions) parser and runner in Rust.
Apache License 2.0
172 stars 45 forks source link

ci: add semver check in CI #167

Closed skyzh closed 1 year ago

skyzh commented 1 year ago

I feel I cannot catch all API changes during my review, and it would be a good idea to use a tool in this case 🤪

skyzh commented 1 year ago

Okay we did accidentally break something. We will need to bump to 0.13 instead of 0.12.1.

melgenek commented 1 year ago

Okay we did accidentally break something. We will need to bump to 0.13 instead of 0.12.1.

I am sorry that I didn't mention a new function parameter explicitly. I wasn't sure how strict the releases in this library are in terms of api compatibility.

Thank you for taking care of this issue!

skyzh commented 1 year ago

No worries! I think we also didn't take this seriously for a long time...