search

risinglightdb / sqllogictest-rs

Sqllogictest parser and runner in Rust.
Apache License 2.0
167 stars 42 forks source link

runner: allow omit column type in query #188

Closed TennyZhuang closed 11 months ago

TennyZhuang commented 11 months ago

If we can't check the column types, or users don't care about that, how about allowing only writing a simple query?

xxchan commented 11 months ago

Good idea

melgenek commented 11 months ago

The default validator just returns true https://github.com/risinglightdb/sqllogictest-rs/blob/main/sqllogictest/src/runner.rs#L438. And the parser without types should not complain as well https://github.com/risinglightdb/sqllogictest-rs/blob/main/sqllogictest/src/parser.rs#L572. And there is a test for a query with no types https://github.com/risinglightdb/sqllogictest-rs/blob/main/sqllogictest/src/parser.rs#L756.

It seems that having no types already works.