risingwavelabs / risingwave-operator

RisingWave Kubernetes Operator
https://www.risingwave.com/cloud
Apache License 2.0
75 stars 18 forks source link

Allow HTTP #631

Closed stefannegele closed 5 months ago

stefannegele commented 5 months ago

Please allow having unsecured HTTP connections to the S3 bucket. The CRD (by regexp validation) and the operator (by prepending https://) do not allow this at the moment.

If someone else stumbles upon this, here's our current workaround:

spec:
  stateStore:
    s3:
      # it is important to not add any endpoint here, otherwise the operator will override the components env settings
      bucket: my-bucket
      credentials:
        secretName: my-secret
        accessKeyRef: AWS_ACCESS_KEY_ID
        secretAccessKeyRef: AWS_SECRET_ACCESS_KEY
# ...
  components:
    meta:
      nodeGroups:
        - replicas: 2
          name: ""
          template:
            spec:
              env:
                - name: RW_S3_ENDPOINT
                  value: http://my-s3/
# ... do the same for other components which need S3 access

Since I know some Go, I can try to create a PR for this, if you want.

arkbriar commented 5 months ago

Hi @stefannegele, thanks for reporting the issue. I believe it exists.

Since I know some Go, I can try to create a PR for this, if you want.

I would appreciate it.

stefannegele commented 5 months ago

Thanks! You've been faster than me :)