search

risingwavelabs / risingwave-operator

RisingWave Kubernetes Operator
https://www.risingwave.com/cloud
Apache License 2.0
75 stars 18 forks source link

feat: support embedded serving mode #651

Closed arkbriar closed 1 month ago

arkbriar commented 1 month ago

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

Checklist

Refer to a related PR or issue link (optional)

chenzl25 commented 1 month ago

I have a doubt. Could the embedded serving nodes be connected to each other?

arkbriar commented 1 month ago

I have a doubt. Could the embedded serving nodes be connected to each other?

Should be able to. The listen IP is 0.0.0.0 and advertise IP is the pod's IP. There's no obstacle to my knowledge will block the communication.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 39.65517% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 55.74%. Comparing base (27ceb40) to head (d7761dd).

Files Patch % Lines
pkg/factory/risingwave_object_factory.go 43.39% 26 Missing and 4 partials :warning:
apis/risingwave/v1alpha1/zz_generated.deepcopy.go 0.00% 4 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #651 +/- ## ========================================== - Coverage 55.98% 55.74% -0.25% ========================================== Files 38 38 Lines 6436 6480 +44 ========================================== + Hits 3603 3612 +9 - Misses 2725 2755 +30 - Partials 108 113 +5 ``` | [Flag](https://app.codecov.io/gh/risingwavelabs/risingwave-operator/pull/651/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=risingwavelabs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/risingwavelabs/risingwave-operator/pull/651/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=risingwavelabs) | `55.74% <39.65%> (-0.25%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=risingwavelabs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.