risingwavelabs / risingwave-operator

RisingWave Kubernetes Operator
https://www.risingwave.com/cloud
Apache License 2.0
75 stars 18 forks source link

fix: use a minimal value of 4 for `RW_WORKER_THREADS` #663

Closed BugenZhao closed 4 months ago

BugenZhao commented 4 months ago

What's changed and what's your intention?

See https://github.com/risingwavelabs/risingwave/issues/16693 for the background.

TL;DR: As we cannot guarantee there's no (unexpected) synchronous I/O call within the asynchronous context in kernel's Rust code, increasing the worker threads number can reduce the possibility of the process being blocked, especially for the free-tier standalone deployment with CPU limit set to 1.

Checklist

Refer to a related PR or issue link (optional)

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.74%. Comparing base (04b2391) to head (1b00249).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #663 +/- ## ======================================= Coverage 55.74% 55.74% ======================================= Files 38 38 Lines 6480 6480 ======================================= Hits 3612 3612 Misses 2755 2755 Partials 113 113 ``` | [Flag](https://app.codecov.io/gh/risingwavelabs/risingwave-operator/pull/663/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=risingwavelabs) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/risingwavelabs/risingwave-operator/pull/663/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=risingwavelabs) | `55.74% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=risingwavelabs#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arkbriar commented 4 months ago

Would you like to make the same change to the https://github.com/risingwavelabs/helm-charts as well?

BugenZhao commented 4 months ago

Would you like to make the same change to the risingwavelabs/helm-charts as well?

Interesting. What changes should I make here?

arkbriar commented 4 months ago

Would you like to make the same change to the risingwavelabs/helm-charts as well?

Interesting. What changes should I make here?

Sorry, my mistake. The env isn't used in chart. Ignore me.