search

risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://go.risingwave.com/slack
Apache License 2.0
7k stars 575 forks source link

Potential misuse of `timestamp` (without time zone) #13448

Open xiangjinwu opened 11 months ago

xiangjinwu commented 11 months ago

timestamptz represents an absolute point in time, while timestamp represents a watch reading including a date and time depending on local law with unpredictable changes.

https://github.com/risingwavelabs/risingwave/blob/4e16834d7ea5df3b8c6d16cc03f0431a34e29fbf/src/frontend/src/catalog/system_catalog/rw_catalog/rw_meta_snapshot.rs#L44-L55

https://github.com/risingwavelabs/risingwave/blob/4e16834d7ea5df3b8c6d16cc03f0431a34e29fbf/src/frontend/src/optimizer/plan_node/logical_source.rs#L181-L186

https://github.com/risingwavelabs/risingwave/blob/4e16834d7ea5df3b8c6d16cc03f0431a34e29fbf/src/stream/src/executor/source/list_executor.rs#L101-L117

xiangjinwu commented 11 months ago

About usage in s3 source: https://github.com/risingwavelabs/risingwave/pull/13414#discussion_r1410276611