search

risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://go.risingwave.com/slack
Apache License 2.0
7.02k stars 577 forks source link

Check data chunk for invisible records before evaluating expressions #14163

Open kwannoel opened 10 months ago

kwannoel commented 10 months ago

https://github.com/risingwavelabs/risingwave/pull/13890#issue-2033777281

The reason is that some expressions ignore the visibility and return non-null values for invisible rows. Examples include literal expression and simd-optimized expressions such as =. The CASE expression doesn't mask invisible rows in the condition result, so later values may override earlier ones.

Continuing on from this, for our data chunks, we should check if they contain any invisible records, before running any expressions on it.

github-actions[bot] commented 4 months ago

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.