risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://go.risingwave.com/slack
Apache License 2.0
6.88k stars 569 forks source link

Ban `CREATE SOURCE` for non-backfillable CDC source #15660

Open xxchan opened 6 months ago

xxchan commented 6 months ago

And the original question: Can we CREATE SOURCE for citus-cdc? If not, where is it rejected?

We can't. But it seems we didn't ban it in code.

   // gated the feature with a session variable
    let create_cdc_source_job = if with_properties.is_cdc_connector() {
        CdcTableType::from_properties(&with_properties).can_backfill()
    } else {
        false
    };

_Originally posted by @StrikeW in https://github.com/risingwavelabs/risingwave/pull/15635#discussion_r1522624926_

github-actions[bot] commented 3 months ago

This issue has been open for 60 days with no activity. Could you please update the status? Feel free to continue discussion or close as not planned.