search

risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://go.risingwave.com/slack
Apache License 2.0
6.78k stars 561 forks source link

support prepared statements for DDL #16653

Open BugenZhao opened 4 months ago

BugenZhao commented 4 months ago

There were no technical issues blocking this. Recently we found some users requesting this feature.

Most of work have done. Remain work: create as with parameter, create view with parameter, create sink with parameter.

But I don't think it's worth to support them beacase:

Can't support ddl with param like create view v as Actually I think it's not necessary because the param is useful for reusing a sql. But for ddl sql, it can't be reused because you can't create a view or table twice. So I think the user may rarely use ddl with param. And if we support it, it will cause the redundant and duplicate code like query handle so that it take effort to maintain or refactor them.

If this point is acceptable, this issue is done.

Originally posted by @ZENOTME in https://github.com/risingwavelabs/risingwave/issues/8112#issuecomment-1499990030

fuyufjh commented 1 month ago

https://github.com/risingwavelabs/risingwave/pull/17769 completes the create materialized view first because it's more useful than the rest. We may complete the rest part later if requested by any users.