Feat: Alter Source|(Table with conns)'s connector's parameters in with option

risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.

https://go.risingwave.com/slack

Apache License 2.0

7.04k stars 579 forks source link

Feat: Alter Source|(Table with conns)'s connector's parameters in with option #18440

Open st1page opened 2 months ago

st1page commented 2 months ago

ALTER TABLE/SOURCE <table name> CONNECTOR [CLEAN STATE] WITH (…)

[ ] without CLEAN STATE
- In this case, just modify the stored parameters in the streaming plans
[ ] with CLEAN STATE, the user can change the table's connector.

more informations here. https://risingwave-labs.slack.com/archives/C069EV2Q5MK/p1721982104476979?thread_ts=1721815617.574089&cid=C069EV2Q5MK

tabVersion commented 1 month ago

In this case, just modify the stored parameters in the streaming plans

Does this mean users can do whatever they want as long as not changing the connector? TBH, I vote for this behavior because it is hard to tell whether we should enforce clean state in some cases, eg. broker SSL cert expires and the broker is mounted to another domain. RisingWave cannot see the two broker_addrs as the same.