Previously in #16816, we used a try_join_all directly on the JoinHandle, which only returns the JoinError, while the error in the output of JoinHandle is ignored, because it is treated as Ok(Err(...)).
In this PR, we transform the future of JoinHandle to a single layer result, so that the error in join handle output will be treated as error.
Checklist
[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added test labels as necessary. See details.
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[x] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)
Documentation
[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Previously in #16816, we used a
try_join_all
directly on theJoinHandle
, which only returns theJoinError
, while the error in the output ofJoinHandle
is ignored, because it is treated asOk(Err(...))
.In this PR, we transform the future of
JoinHandle
to a single layer result, so that the error in join handle output will be treated as error.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.