risingwavelabs / risingwave

Best-in-class stream processing, analytics, and management. Perform continuous analytics, or build event-driven applications, real-time ETL pipelines, and feature stores in minutes. Unified streaming and batch. PostgreSQL compatible.
https://go.risingwave.com/slack
Apache License 2.0
7.07k stars 582 forks source link

fix(starrocks): fix starrocks coordinator incorrect try_join_all on join handle #19412

Closed wenym1 closed 1 week ago

wenym1 commented 1 week ago

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously in #16816, we used a try_join_all directly on the JoinHandle, which only returns the JoinError, while the error in the output of JoinHandle is ignored, because it is treated as Ok(Err(...)).

In this PR, we transform the future of JoinHandle to a single layer result, so that the error in join handle output will be treated as error.

Checklist

Documentation

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

wenym1 commented 1 week ago

Many thanks for @ly9chee to help locate the bug!